Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing top-level HAL links (except for /POST transactions) #2407

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Add missing top-level HAL links (except for /POST transactions) #2407

merged 1 commit into from
Mar 24, 2020

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Mar 24, 2020 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Addresses part of #2402

This change adds the missing top-level HAL links to GET /, with the exception of POST /transactions which clashes with GET /transactions and isn't properly covered by HAL.

@2opremio
Add missing top-level HAL links (except for /POST transactions)
78828e5 
This change adds the missing top-level HAL links to `GET /`, with
the exception of `POST /transactions` which clashes with
`GET /transactions` and isn't properly covered by HAL.
@cla-bot cla-bot bot added the cla: yes label Mar 24, 2020
@2opremio 2opremio merged commit 87c469e into release-horizon-v1.1.0 Mar 24, 2020
@2opremio 2opremio deleted the 2402-add-missing-hal-links branch March 24, 2020 15:31
@2opremio 2opremio mentioned this pull request Apr 3, 2020
Merged
@ire-and-curses ire-and-curses modified the milestone: Horizon 1.1.0 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch leighmcculloch left review comments

@ire-and-curses ire-and-curses ire-and-curses left review comments

@abuiles abuiles abuiles approved these changes

@tomerweller tomerweller Awaiting requested review from tomerweller

@tamirms tamirms Awaiting requested review from tamirms

@JakeUrban JakeUrban Awaiting requested review from JakeUrban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2opremio @abuiles @leighmcculloch @ire-and-curses